Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (<$$>) to Functor. #20509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

yangzai
Copy link
Contributor

@yangzai yangzai commented Dec 19, 2024

Useful for manipulating Optionals or lists nested in Update/Script we often get from the query/fetch/lookup functions (in the absence of functor composition or monad transformers).

In general, it would still be useful for all effectful functions in the Kleisli form. Sometimes (<=<) is an over kill, and it wouldn't even work for non-monadic applicatives like Commands and Validation.

The fixity follows the version from https://hackage.haskell.org/package/composition-extra-2.1.0/docs/Data-Functor-Syntax.html .

@yangzai yangzai requested a review from a team as a code owner December 19, 2024 18:11
@yangzai yangzai changed the title Add nested fmap to Functor. Add (<$$>) to Functor. Dec 19, 2024
Copy link
Contributor

@paulbrauner-da paulbrauner-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@paulbrauner-da
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@paulbrauner-da paulbrauner-da enabled auto-merge (squash) January 8, 2025 10:19
@paulbrauner-da
Copy link
Contributor

This breaks the platform independence tests. Would you mind running

bazel run //compiler/damlc/tests:platform-independence-dar-hash-file-matches -- --accept

and committing the resulting changes?

auto-merge was automatically disabled January 8, 2025 14:30

Head branch was pushed to by a user without write access

@samuel-williams-da
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@yangzai
Copy link
Contributor Author

yangzai commented Jan 8, 2025

This breaks the platform independence tests. Would you mind running

bazel run //compiler/damlc/tests:platform-independence-dar-hash-file-matches -- --accept

and committing the resulting changes?

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants